Publish confirmed transactions by address #1198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaladinlight
force-pushed
the
pub-new-block-txs
branch
2 times, most recently
from
b5dd84c to
fe7b7fa
Compare
martinboehm
reviewed
Feb 13, 2025
martinboehm
reviewed
Feb 13, 2025
kaladinlight
force-pushed
the
pub-new-block-txs
branch
from
b7311c9 to
a4b81b9
Compare
kaladinlight
force-pushed
the
pub-new-block-txs
branch
2 times, most recently
from
89f62d2 to
434394b
Compare
kaladinlight
force-pushed
the
pub-new-block-txs
branch
from
434394b to
920cde2
Compare
kaladinlight
force-pushed
the
pub-new-block-txs
branch
from
920cde2 to
b82c433
Compare
kaladinlight
force-pushed
the
pub-new-block-txs
branch
from
b82c433 to
b74b9d9
Compare
kaladinlight
force-pushed
the
pub-new-block-txs
branch
from
b74b9d9 to
7de2a79
Compare
|
@kaladinlight is this a finished PR ready for review? |
@etimofeeva yep, it is ready to go! |
kaladinlight
force-pushed
the
pub-new-block-txs
branch
from
7de2a79 to
3223295
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for publishing confirmed transaction notifications directly to clients subscribed to specific addresses, bypassing the need to repeatedly fetch blocks from blockbook. This optimizes performance on high-throughput chains like Base by leveraging already-parsed sync blocks to detect relevant transactions and only fetching receipts when needed.
- Adds
newBlockTxsparameter tosubscribeAddressesfor opting into confirmed transaction notifications - Refactors address subscription tracking to include per-subscription configuration details
- Updates the block processing pipeline to pass full block objects instead of just hash/height
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| static/test-websocket.html | Adds UI checkbox for testing the new newBlockTxs option |
| server/ws_types.go | Adds NewBlockTxs boolean field to subscription request struct |
| server/websocket.go | Core implementation of confirmed transaction publishing with subscription tracking |
| server/public.go | Updates block notification interface to pass full block objects |
| docs/api.md | Documents the new optional parameter with example usage |
| db/sync.go | Updates block processing callback to pass block objects |
| blockbook.go | Updates callback function signatures for block processing |
| blockbook-api.ts | Adds TypeScript interface for the new optional parameter |
| bchain/types.go | Updates callback signature and adds transaction receipt method |
| bchain/coins/eth/ethrpc.go | Refactors and exposes transaction receipt fetching method |
| bchain/coins/blockchain.go | Adds metrics wrapper for new transaction receipt method |
| bchain/basechain.go | Provides default implementation for transaction receipt method |
| api/worker.go | Exposes transaction conversion method for external use |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in order to push confirmed transaction notifications to a client, you have to:
Historically this has worked without any noticeable issue, however in integrating Base, I have noticed this no longer holds up due to the fast block times and high transaction throughput on chain. The node gets oversaturated with network requests causing it to fall out of sync along with blockbook. Even when they are staying in sync, I was seeing calls to get a block taking more than 30 minutes. I did make many attempts at increasing resources, cache sizes, etc. to improve performance without avail.
To reduce most overhead related to this scenario, I chose to add an optional
newBlockTxsparam tosubscribeAddresseswhich will allow subscribing to addresses for mempool AND confirmed transactions now. By leveraging the mostly parsed sync blocks, we can detect all associated addresses for a transaction to determine if a confirmed transaction should be published to a client and only then, fetch the evm transaction receipt to ensure anapi.Txis sent to the client. This update cuts down nearly all of the previously seen network requests and completely fixed the performance issues seen in the above scenario.(I went with
newBlockTxsjust to tie into the new block vernacular, but could update toconfirmedTxsif that sounds better.)